fix(skymp5-server): debug crash #2213
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 638e4a0 in 1 minute and 5 seconds
More details
- Looked at
85lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skymp5-server/cpp/server_guest_lib/MpObjectReference.cpp:1175
- Draft comment:
Remove the commented-outstd::terminate();line to avoid confusion. - Reason this comment was not posted:
Confidence changes required:50%
The PR modifies theApplyChangeFormfunction to log critical information instead of terminating the program. However, the commented-outstd::terminate()line should be removed to avoid confusion.
2. skymp5-server/cpp/server_guest_lib/MpObjectReference.cpp:32
- Draft comment:
Ensure that<stacktrace>is supported in the build environment or provide an alternative for older C++ standards. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_JRa0iFqT4pN0vLXW
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -1129,8 +1146,33 @@ MpChangeForm MpObjectReference::GetChangeForm() const | |||
| void MpObjectReference::ApplyChangeForm(const MpChangeForm& changeForm) | |||
There was a problem hiding this comment.
Consider resetting pImpl->setPropertyTrackingInfo after logging in ApplyChangeForm to avoid incorrect logging in subsequent calls.
|
Maybe close? It won't work without either C++23 on (which needs at least a clang update) or |
|
@nic11 could u please send a link to a discord topic where we were discussing this. Also I want to introduce formal rules for closing PRs due to inactivity. CLosing important PRs should always lead to a ticket creation |
Important
Enhance debugging in
MpObjectReference.cppby tracking property changes and logging detailed information whenApplyChangeFormis called afterSetProperty.SetPropertyTrackingInfostruct to track property changes inMpObjectReference.cpp.SetProperty()whenGetFormId()is0xE2218.ApplyChangeForm()if called afterSetProperty().std::terminate()with detailed logging inApplyChangeForm()to provide more context on errors.This description was created by
for 638e4a0. It will automatically update as commits are pushed.